Cryosphere Datapool information page#1063
Conversation
|
Hi @headmetal, thank you for this PR! The title says "DRAFT", but the PR is not a draft. Thank you |
|
@headmetal as alluded at this morning's team leads.. Here's @joshuatorrance's magic for live search on big tables. @ACCESS-NRI/ocean we briefly discussed last Wednesday whether it was needed to have a list of available datasets for evaluation, have a look at this for an example of what the cryosphere folks are doing. Could be worth considering for our |
781e8dd to
01de913
Compare
254ca6a to
963790e
Compare
|
@ACCESS-NRI/hivedocsteam -- This PR is now ready for review! One question -- You'll see that there are lots of Gadi filepaths in the table(s). I wondered if it's possible to add "copy-to-clipboard" buttons in these cells, so that users can easily copy the relevant filepath? I've no idea how easy that is to implement, but thought I'd ask the question for you to consider while you review this! Thanks heaps. |
The "copy-to-clipboard" button is added to "fenced codeblocks": but within markdown tables this is not allowed. <pre><code>/g/data/project/path/to/data</code></pre>This works and writes the path in one code block and adds a "copy-to-clipboard" button at the top-right of it. |
|
Thanks @atteggiani -- that worked great! I've made that update. I'll leave it with the @ACCESS-NRI/hivedocsteam for review now. Thanks! |
atteggiani
left a comment
There was a problem hiding this comment.
Thank you @headmetal and @lawrenceabird for working on this new page!
The additional page looks nice. Overall it's pretty long due to the number of listed datasets, and it could be potentially improved in the future by connecting to an API (the cryosphere-data-catalog API?) for querying the data in a more efficient way.
But for the moment I think it looks good!
I left some comments for minor adjustments.
Also note there are some commits (and changes) that are not relevant to this PR.
I would suggest leaving only the commits strictly related to this PR (and probably interactively rebase to reduce the number of total commits). I would suggest doing this process at the very end, when the reviews are finalised and the PR content is ready to be merged.
There was a problem hiding this comment.
This change should be removed.
There was a problem hiding this comment.
This change should be removed.
.readthedocs/scripts/check_links.sh
Outdated
There was a problem hiding this comment.
This change should be removed.
|
Thanks @atteggiani for the review!
This page is simply intended to document all the data that's available. It likely won't get any shorter in the future (we'd love it to grow as we add more data!). But you're right - As the API comes to life, people will be able to search the datapool on Gadi using the API. However, we'll maintain this page so people can see a listing of datasets without the need to access Gadi. I've address all your comments for minor adjustments. I've left the ones that "should be removed" so these can be cleaned up once you're happy with all the content. |
There was a problem hiding this comment.
Thank you @lawrenceabird for addressing the comments!
This looks pretty good.
I will go on and clean it (some commits in the history are not related to this PR) and then squash-merge it.
Added image and link to "Data"
Check links / check-links / check-links (pull_request)Failing after 52s
Changed button/icon position in "Data" card stack
Set button link to cryosphere_datapool.md
Add "Cryosphere Datapool" menu item
Testing table layout and structure
Added html search bar to test if datapool table can be searched 'inline'
WIP - Publishing table content
Dataset table complete - still needs some missing links Draft contribution section included
Removed code snippet
Added image and link to "Data"
Check links / check-links / check-links (pull_request)Failing after 52s
Changed button/icon position in "Data" card stack
Updated Gadi paths for: - Elevation models & geometry data - Ice velocity data
Co-authored-by: Davide Marchegiani <davide.marchegiani@anu.edu.au>
Co-authored-by: Davide Marchegiani <davide.marchegiani@anu.edu.au>
f644335 to
05cc439
Compare
Added image and link to "Data"
ACCESS-Hive Docs
Thank you for submitting a pull request to the ACCESS-Hive Docs Project. 🎉
More assistance is available in the how to contribute section on ACCESS-Hive Docs
Description
Initial update - Cryosphere Datapool information page
Type of change
Please delete options that are not relevant.
Checklist:
When your pull request is ready please request a review.
Unless there is a specific person you want your PR to be reviewd by, please select the Hive Docs Team:
ACCESS-NRI/hivedocsteam. This ensures the load for reviewing pull requests is shared equitably.