Skip to content

Cryosphere Datapool information page#1063

Merged
atteggiani merged 24 commits intodevelopmentfrom
mike/cryosphere-datapool-info-1062
Dec 22, 2025
Merged

Cryosphere Datapool information page#1063
atteggiani merged 24 commits intodevelopmentfrom
mike/cryosphere-datapool-info-1062

Conversation

@headmetal
Copy link
Copy Markdown
Contributor

@headmetal headmetal commented Nov 10, 2025

Added image and link to "Data"

ACCESS-Hive Docs

Thank you for submitting a pull request to the ACCESS-Hive Docs Project. 🎉

More assistance is available in the how to contribute section on ACCESS-Hive Docs

Description

Initial update - Cryosphere Datapool information page

Type of change

Please delete options that are not relevant.

  • New link / content

Checklist:

  • The new content is accessible and located in the appropriate section
  • My changes do not break navigation and do not generate new warnings
  • I have checked that the links are valid and point to the intended content
  • I have checked my code/text and corrected any misspellings

When your pull request is ready please request a review.

Unless there is a specific person you want your PR to be reviewd by, please select the Hive Docs Team: ACCESS-NRI/hivedocsteam. This ensures the load for reviewing pull requests is shared equitably.

@headmetal headmetal requested a review from a team as a code owner November 10, 2025 03:51
@headmetal headmetal self-assigned this Nov 10, 2025
@atteggiani
Copy link
Copy Markdown
Contributor

Hi @headmetal, thank you for this PR!

The title says "DRAFT", but the PR is not a draft.
Are you already asking for a review (PR is not a draft anymore)? In that case could you please delete "DRAFT" from the title?
Otherwise, if this PR is still a draft, can you still delete "DRAFT" from the title and mark the PR as a draft instead?

Thank you

@headmetal headmetal marked this pull request as draft November 10, 2025 07:44
@headmetal headmetal changed the title DRAFT - Initial update - Added button/link to Data page Initial update - Added button/link to Data page Nov 10, 2025
@headmetal headmetal changed the title Initial update - Added button/link to Data page Cryosphere Datapool information page Nov 12, 2025
@chrisb13
Copy link
Copy Markdown
Contributor

@headmetal as alluded at this morning's team leads.. Here's @joshuatorrance's magic for live search on big tables.


@ACCESS-NRI/ocean we briefly discussed last Wednesday whether it was needed to have a list of available datasets for evaluation, have a look at this for an example of what the cryosphere folks are doing. Could be worth considering for our av17 data?

@atteggiani atteggiani force-pushed the mike/cryosphere-datapool-info-1062 branch 3 times, most recently from 781e8dd to 01de913 Compare November 25, 2025 04:29
@lawrenceabird lawrenceabird self-assigned this Dec 8, 2025
@lawrenceabird lawrenceabird marked this pull request as ready for review December 8, 2025 23:11
@lawrenceabird
Copy link
Copy Markdown
Contributor

@ACCESS-NRI/hivedocsteam -- This PR is now ready for review!

One question -- You'll see that there are lots of Gadi filepaths in the table(s). I wondered if it's possible to add "copy-to-clipboard" buttons in these cells, so that users can easily copy the relevant filepath? I've no idea how easy that is to implement, but thought I'd ask the question for you to consider while you review this!

Thanks heaps.

@atteggiani
Copy link
Copy Markdown
Contributor

atteggiani commented Dec 9, 2025

@ACCESS-NRI/hivedocsteam -- This PR is now ready for review!

One question -- You'll see that there are lots of Gadi filepaths in the table(s). I wondered if it's possible to add "copy-to-clipboard" buttons in these cells, so that users can easily copy the relevant filepath? I've no idea how easy that is to implement, but thought I'd ask the question for you to consider while you review this!

Thanks heaps.

The "copy-to-clipboard" button is added to "fenced codeblocks":

```
This is a fenced codeblock with "copy-to-clipboard" button
```

but within markdown tables this is not allowed.
What you can do, however, is using the HTML solution, which is wrapping the path in <pre><code> ... </code></pre> tags.
So the link /g/data/project/path/to/data would become:

<pre><code>/g/data/project/path/to/data</code></pre>

This works and writes the path in one code block and adds a "copy-to-clipboard" button at the top-right of it.

@lawrenceabird
Copy link
Copy Markdown
Contributor

Thanks @atteggiani -- that worked great! I've made that update. I'll leave it with the @ACCESS-NRI/hivedocsteam for review now.

Thanks!

@lawrenceabird lawrenceabird marked this pull request as draft December 15, 2025 20:56
@lawrenceabird lawrenceabird marked this pull request as ready for review December 15, 2025 21:15
Copy link
Copy Markdown
Contributor

@atteggiani atteggiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @headmetal and @lawrenceabird for working on this new page!

The additional page looks nice. Overall it's pretty long due to the number of listed datasets, and it could be potentially improved in the future by connecting to an API (the cryosphere-data-catalog API?) for querying the data in a more efficient way.
But for the moment I think it looks good!

I left some comments for minor adjustments.

Also note there are some commits (and changes) that are not relevant to this PR.
I would suggest leaving only the commits strictly related to this PR (and probably interactively rebase to reduce the number of total commits). I would suggest doing this process at the very end, when the reviews are finalised and the PR content is ready to be merged.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be removed.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be removed.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be removed.

@lawrenceabird
Copy link
Copy Markdown
Contributor

Thanks @atteggiani for the review!

The additional page looks nice. Overall it's pretty long due to the number of listed datasets, and it could be potentially improved in the future by connecting to an API (the cryosphere-data-catalog API?) for querying the data in a more efficient way.
But for the moment I think it looks good!

This page is simply intended to document all the data that's available. It likely won't get any shorter in the future (we'd love it to grow as we add more data!). But you're right - As the API comes to life, people will be able to search the datapool on Gadi using the API. However, we'll maintain this page so people can see a listing of datasets without the need to access Gadi.

I've address all your comments for minor adjustments. I've left the ones that "should be removed" so these can be cleaned up once you're happy with all the content.

Copy link
Copy Markdown
Contributor

@atteggiani atteggiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lawrenceabird for addressing the comments!
This looks pretty good.

I will go on and clean it (some commits in the history are not related to this PR) and then squash-merge it.

Added image and link to "Data"
Check links / check-links / check-links (pull_request)Failing after 52s
Changed button/icon position in "Data" card stack
Set button link to cryosphere_datapool.md
Add "Cryosphere Datapool" menu item
Testing table layout and structure
Added html search bar to test if datapool table can be searched 'inline'
WIP - Publishing table content
headmetal and others added 16 commits December 23, 2025 09:40
Dataset table complete - still needs some missing links
Draft contribution section included
Removed code snippet
Added image and link to "Data"
Check links / check-links / check-links (pull_request)Failing after 52s
Changed button/icon position in "Data" card stack
Updated Gadi paths for:

- Elevation models & geometry data
- Ice velocity data
Co-authored-by: Davide Marchegiani <davide.marchegiani@anu.edu.au>
Co-authored-by: Davide Marchegiani <davide.marchegiani@anu.edu.au>
@atteggiani atteggiani force-pushed the mike/cryosphere-datapool-info-1062 branch from f644335 to 05cc439 Compare December 22, 2025 22:55
@atteggiani atteggiani merged commit 350c7b4 into development Dec 22, 2025
43 checks passed
@atteggiani atteggiani deleted the mike/cryosphere-datapool-info-1062 branch December 22, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants