move everything out of entity tables into CFW.#19
Draft
Python1320 wants to merge 1 commit into
Draft
Conversation
Author
|
Now tested with multiple dupes in multiplayer with multiple players and so far so good, might be worth cleaning up, but need someone who actually knows the codebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #18
DRAFT: Unfortunately coded with opencode big pickle AND validation pending.
I tried reviewing it and I don't see anything wrong immediately, but it did make a few unrelated changes I'll need to clean out of the commit.
I also added the GetContraption change warning and removal as this will probably be a bit of a breaking change in any case.
Could probably have GetContraption warning go in first though as that won't be breaking, then we commit this somewhere in the future along with GetContraption.
Could be made more advanced by checking current stack if it's from wiremod or CFW/ACF.