fix: resample audio when sample rates differ in merge_audio#107
Open
Mr-Neutr0n wants to merge 1 commit into
Open
fix: resample audio when sample rates differ in merge_audio#107Mr-Neutr0n wants to merge 1 commit into
Mr-Neutr0n wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
merge_audio()function inaudio-chatgpt.pyconcatenates two audio signals without checking if they have matching sample rates. Whensr_1 != sr_2, the first audio segment is written at the wrong sample rate (sr_2), causing it to play back at the wrong speed and pitch, producing corrupted audio output.signal_1to matchsr_2using numpy linear interpolation before concatenation. This requires no additional dependencies since numpy is already imported.Details
Before:
sr_1was read from the first audio file but never used or validated. The merged output always usedsr_2, so if the two files had different sample rates, the first segment would be distorted.After: If
sr_1 != sr_2, the first signal is resampled tosr_2usingnp.interpwith linearly spaced indices, preserving the original duration while matching the target sample rate.Test plan