Fix pyright issues and improve type safety in Dagster Delta#52
Closed
ismailtsdln wants to merge 1 commit intoASML-Labs:mainfrom
Closed
Fix pyright issues and improve type safety in Dagster Delta#52ismailtsdln wants to merge 1 commit intoASML-Labs:mainfrom
ismailtsdln wants to merge 1 commit intoASML-Labs:mainfrom
Conversation
Collaborator
|
I was just about to implement a couple of the same fixes in another PR, but pull them out to make it on this one. I'll finish review after #51 is merged to avoid the upcoming merge conflict, if it runs on my local then I'll approve too. |
Collaborator
|
@ismailtsdln also fell free to send me a PR to my branch so I push this in one go with the new release! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes
Type Safety Improvements
This resolves Pyright errors caused by incompatible method overrides.
Added Pyright ignore directives for legacy Dagster import paths that are still required for backward compatibility.
This prevents false-positive static analysis errors when running against newer Dagster versions.
Verification Tests
Ran the full test suite; all tests passed successfully (55/55):
uv run pytest libraries/dagster-delta/dagster_delta_testsStatic Analysis
Ran Pyright across the entire repository with zero reported errors:
uv run pyright .