Add support for hostname validation feature.#53
Open
mrigaya wants to merge 1 commit intoASPLes:masterfrom
Open
Add support for hostname validation feature.#53mrigaya wants to merge 1 commit intoASPLes:masterfrom
mrigaya wants to merge 1 commit intoASPLes:masterfrom
Conversation
Author
|
@francisbrosnan any suggestion on this pull request? |
Member
|
Hello @mrigaya |
|
The CLA should be covered now, per Jorge. Please let us know otherwise. |
|
@francisbrosnan Thanks for your time and considerations, please let us know if there is any update/suggestion on this PR. |
Member
|
Hello @selvamKrish, just acknoledge your message. We didn't have time to review this. We'll keep you updated as soon as possible. Best Regards. |
Contributor
|
@francisbrosnan have you had any cycles to look at this code? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per openssl wiki page https://wiki.openssl.org/index.php/Hostname_validation, openssl version prior to 1.0.2 doesn't perform hostname validation. So nopoll users should handle the hostname validation part during connection handshake at the client end.
This code can help users to enable/disable hostname validation feature based on the options they are providing during the TLS connect. As we could see in the computer security this man in the middle attack is most common security threats faced by the current world, So it is better to enable hostname validation by default and we did the same here. And also user may not be aware of this hostname validation is not handled in their openssl in case if they are using the openssl version < 1.0.2.
Review these changes and Please let me know if it requires any modification/suggestion from your end.