Add flake node implementations #2676
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ld-kerley
reviewed
Nov 13, 2025
| @@ -1,4 +1,5 @@ | |||
| #define M_FLOAT_EPS 1e-8 | |||
| #define M_PI 3.1415926535897932 | |||
Contributor
There was a problem hiding this comment.
Metal defines M_PI_F along with other constants - if you'd be to defining it that way we could avoid specifying it all in mx_math.metal.
Contributor
Author
There was a problem hiding this comment.
M_PI is already used here (but can't reference it from stdlib) so I think we want to keep this for consistency.
Contributor
There was a problem hiding this comment.
OK - then maybe it makes sense in mx_math.metal to say
#define M_PI M_PI_F
Contributor
Author
There was a problem hiding this comment.
Sounds good, done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds GLSL and MDL implementations for the flake nodes proposed in #2609.
Nodes to add:
<flake2d><flake3d>