Skip to content

Add Nango function builder persona#63

Open
khaliqgant wants to merge 2 commits intomainfrom
codex/nango-functions-persona
Open

Add Nango function builder persona#63
khaliqgant wants to merge 2 commits intomainfrom
codex/nango-functions-persona

Conversation

@khaliqgant
Copy link
Copy Markdown
Member

Summary

  • Add the built-in nango-function-builder persona and sidecar AGENTS.md
  • Wire intent nango-function-building through workload-router catalog, routing profile, schema, tests, and generated persona output
  • Document the persona in repo and workload-router READMEs

Validation

  • corepack pnpm --filter @agentworkforce/workload-router test

Notes

  • corepack pnpm run check currently fails in the existing CLI package before this persona change, due missing/mismatched @agentworkforce/harness-kit exports and missing @relayburn/sdk types.
  • Existing untracked .claude/ was left untouched.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 10, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d37fc645-fb6a-4f95-beb5-1caeaac23a44

📥 Commits

Reviewing files that changed from the base of the PR and between 4d75260 and 98813dd.

⛔ Files ignored due to path filters (1)
  • packages/workload-router/src/generated/personas.ts is excluded by !**/generated/**
📒 Files selected for processing (1)
  • personas/nango-function-builder/AGENTS.md

📝 Walkthrough

Walkthrough

Adds a built-in persona "nango-function-builder" (persona spec + AGENTS.md), registers it in routing/schema and personaCatalog, updates generate/export wiring, expands tests for persona resolution, and updates README docs to list the new built-in personas.

Changes

Nango Function Builder Persona Addition

Layer / File(s) Summary
Persona Definition & Guidance
personas/nango-function-builder.json, personas/nango-function-builder/AGENTS.md
New persona config defines nango-function-building intent with best/best-value/minimum tiers, harness settings, and system prompts. AGENTS.md provides a checklist and local validation workflow for building Nango TypeScript actions/syncs.
Intent Routing Configuration
packages/workload-router/routing-profiles/default.json, packages/workload-router/routing-profiles/schema.json
Adds nango-function-building to default.json with best-value tier and updates schema required intent keys and properties mapping.
Persona Registration & Wiring
packages/workload-router/scripts/generate-personas.mjs, packages/workload-router/src/index.ts
Adds export map entry nango-function-builder → nangoFunctionBuilder, imports generated spec, extends BUILT_IN_PERSONA_INTENTS, and registers personaCatalog['nango-function-building'].
Test Coverage
packages/workload-router/src/index.test.ts
Updates built-in persona ID expectations and adds tests asserting resolvePersona('nango-function-building') returns expected tier (best-value), harness (codex), skill (building-nango-functions-locally), agentsMdContent, and workspace network access.
Documentation
README.md, packages/workload-router/README.md
Root and package READMEs updated to list persona-maker, persona-improver, and nango-function-builder as built-in internal personas and to clarify persona resolution/install guidance.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Poem

🐰 I hopped through specs and README lines,
Three personas now in tidy signs,
Nango builds with TypeScript cheer,
Checkpoints, dryruns, tests appear,
The workforce grows — a hop, no fears!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and clearly describes the main change: adding a new Nango function builder persona. It is concise, specific, and accurately reflects the primary objective of the changeset.
Description check ✅ Passed The description provides relevant context about the changeset, detailing the addition of the persona, integration with workload-router systems, documentation updates, and validation steps.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/nango-functions-persona

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@khaliqgant
Copy link
Copy Markdown
Member Author

Updated in 98813dd to make the Nango skill install behavior explicit:

  • The persona now names the workload-router dry-run/session materializer command: npx -y skills add https://github.com/NangoHQ/skills --skill building-nango-functions-locally -y.
  • It also includes the manual scratch-session equivalent requested here: npx skills add NangoHQ/skills -s building-nango-functions-locally.
  • It keeps the repo convention that installers should not run against the repo root, and adds a reminder to discover Nango integrations/connections before choosing dryrun args.

Validation: corepack pnpm --filter @agentworkforce/workload-router test and git diff --check pass.

@willwashburn
Copy link
Copy Markdown
Member

@khaliqgant I'm not sure this should be a built in workforce persona.

see https://github.com/AgentWorkforce/workforce/pull/43/changes for reference, but workforce has installable libraries we can leverage, this maybe is one? could be it's own package/repo as the nango set of personas?

@khaliqgant
Copy link
Copy Markdown
Member Author

@khaliqgant I'm not sure this should be a built in workforce persona.

see https://github.com/AgentWorkforce/workforce/pull/43/changes for reference, but workforce has installable libraries we can leverage, this maybe is one? could be it's own package/repo as the nango set of personas?

I don't understand why not actually. This is a persona for building nango-integrations, in my mind a perfect use case for a persona with a specific set of skills and silo'ed directory. I'm misunderstanding personas, it seems?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants