fix(mdstream): clamp stable line count to prevent dropping lines shorter than live window - #5659
Open
lx3133584 wants to merge 1 commit into
Open
fix(mdstream): clamp stable line count to prevent dropping lines shorter than live window#5659lx3133584 wants to merge 1 commit into
lx3133584 wants to merge 1 commit into
Conversation
…ter than live window Fixes Aider-AI#5654 Signed-off-by: Liang Xu <lx3133584@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the rendered output is shorter than
live_window,MarkdownStream.updatecomputes a negativenum_lines(len(lines) - self.live_window), which causes Python slicelines[num_lines:]to drop leading rendered lines from the Rich live display instead of displaying all lines.Root Cause
In
aider/mdstream.py,num_lines -= self.live_windowyields a negative index whenlen(lines) < self.live_window. Slicing with a negative index takes only the suffix rather than treating the stable line count as 0.Fix
Clamp
num_linesto 0 withmax(0, num_lines - self.live_window).Testing
Added unit tests in
tests/basic/test_mdstream.pycovering short window preservation and stable line emission, verified with pytest.