Skip to content

bar: warn on invalid height type in configuration#4951

Open
B2krobbery wants to merge 1 commit intoAlexays:masterfrom
B2krobbery:fix-height-type-warning
Open

bar: warn on invalid height type in configuration#4951
B2krobbery wants to merge 1 commit intoAlexays:masterfrom
B2krobbery:fix-height-type-warning

Conversation

@B2krobbery
Copy link
Copy Markdown
Contributor

@B2krobbery B2krobbery commented Mar 25, 2026

Waybar currently accepts invalid values such as "height": null
without emitting any warning, silently falling back to 0.

However, Waybar already emits warnings for other invalid values
(e.g. when height is below the minimum allowed). This creates
inconsistent behavior where some invalid inputs are reported,
while others are silently ignored.

This change ensures that invalid types for height are also
reported with a warning, improving consistency and helping users
identify configuration issues.

Testing

  • Set "height": null in config → warning is shown
  • Removed height key → no warning
  • Set valid value ("height": 22 or higher) → no warning
  • Set small value ("height": 20) → existing warning still works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant