bar: warn on invalid height type in configuration#4951
Open
B2krobbery wants to merge 1 commit intoAlexays:masterfrom
Open
bar: warn on invalid height type in configuration#4951B2krobbery wants to merge 1 commit intoAlexays:masterfrom
B2krobbery wants to merge 1 commit intoAlexays:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waybar currently accepts invalid values such as
"height": nullwithout emitting any warning, silently falling back to 0.
However, Waybar already emits warnings for other invalid values
(e.g. when height is below the minimum allowed). This creates
inconsistent behavior where some invalid inputs are reported,
while others are silently ignored.
This change ensures that invalid types for
heightare alsoreported with a warning, improving consistency and helping users
identify configuration issues.
Testing
"height": nullin config → warning is shownheightkey → no warning"height": 22or higher) → no warning"height": 20) → existing warning still works