fix(config): respect ethereum.local default_provider overrides#2760
Open
sanjaysudagani wants to merge 1 commit intoApeWorX:mainfrom
Open
fix(config): respect ethereum.local default_provider overrides#2760sanjaysudagani wants to merge 1 commit intoApeWorX:mainfrom
sanjaysudagani wants to merge 1 commit intoApeWorX:mainfrom
Conversation
antazoey
reviewed
Mar 4, 2026
| if not (override := (self.__pydantic_extra__ or {}).get("local")): | ||
| return default_local | ||
|
|
||
| if isinstance(override, NetworkConfig): |
Member
There was a problem hiding this comment.
do we also want to merge here (like we do for dict)? just have to dump it first if that's the case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Updated the config model so project/global overrides for
ethereum.local.default_providerare reflected inEthereumConfig.local.fixes: #2490
How I did it
localoverride from the plugin extras instead of always constructing a hard-coded local configlocalvalues with the existing local defaults before validating asNetworkConfigethereum.local.default_provideroverride behaviorHow to verify it
pytest tests/functional/test_config.py -k ethereum_local_network_config_override -q pytest tests/functional/test_network_api.py -k "gas_limit_defaults or gas_limit_configured_max or base_fee_multiplier or config_custom_networks_default or config_custom_networks" -qChecklist