Open
Conversation
fubuloubu
approved these changes
Sep 23, 2025
fubuloubu
reviewed
Sep 23, 2025
|
|
||
|
|
||
| def test_0x(): | ||
| model = IntModel(value="0x") |
Member
There was a problem hiding this comment.
Question though, wouldn't this be like "empty bytes" instead of the number 0?
Member
Author
There was a problem hiding this comment.
It is, but wondering what should the behavior be when a model gets it for a hexint
Member
There was a problem hiding this comment.
Feel like it should raise
Maybe it doesn't matter, a parameter using HexInt should always expect a value but seems unnecessary to have it raise just for empty if someone makes a small mistake
Member
There was a problem hiding this comment.
e.g. you can do a = 0x0 in python, but a = 0x wouldn't parse
Member
Author
There was a problem hiding this comment.
Tbh I can't remember why I ran into this problem so raising might be OK
fubuloubu
changed the title
"0x" value not working on HexIntHexInt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
fixes: #
How I did it
How to verify it
Checklist