fix(Router): add setting payer_is_user= kwarg for plan#26
Open
fix(Router): add setting payer_is_user= kwarg for plan#26
payer_is_user= kwarg for plan#26Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Noticed that it wasn't really possible to do a swap with Safe (in a simulation context), so adding this kwarg allows the pass-through of the critical
payer_is_user=kwarg so you can simulate a swap with a Safe by first sending tokens to the Universal Router (NOTE: this should NOT be used for production, as your tokens will disappear)I tried testing it using the
propose_from_simulationcapability of ape-safe, but realized for some use cases it wouldn't work very well in practice when handling the values given after the swap (but you can do a swap with this now!)How I did it
How to verify it
Checklist