Make pull honor parameters#2
Open
tomascohen wants to merge 4 commits into
Open
Conversation
Create pkg/compose package with GetComposeFiles function that builds a list of compose files based on provided options (debugging, dbgui). This centralizes the logic for determining which compose files to use, making it reusable across commands like 'up' and 'pull'.
Replace inline compose file building logic with compose.GetComposeFiles. This simplifies the code and ensures consistency in how compose files are selected based on flags.
Replace the filepath.Walk approach that pulled ALL compose files with selective pulling based on flags (--debugging, --dbgui). Use 'docker compose pull' instead of pulling individual images, which is simpler and more efficient. Now 'adb pull' only pulls images from the base compose file, and 'adb pull --dbgui' pulls base + phpmyadmin images, matching the behavior of 'adb up'. This prevents unnecessary image pulls (e.g., phpmyadmin when not needed) and makes the pull command consistent with the up command.
Contributor
Author
|
I tested it on |
Jacobomara901
added a commit
to Jacobomara901/aspen-dev-box-cli
that referenced
this pull request
Feb 9, 2026
Replace filepath.Walk approach that pulled ALL compose images with selective pulling based on flags (--debugging, --dbgui, --evergreen). Use 'docker compose pull' via Compose.Pull() instead of pulling individual images, consistent with the up command pattern. Adapted from Aspen-Discovery#2 by Tomás Cohen Arazi.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.