Timeout site stop --all after 6s when quitting
#2475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Related issues
Proposed Changes
When Studio quits, the
stopAllServersfunction runs thesite stop --allCLI command to stop running sites. This function resolves if the command fails or if the Node.jsChildProcessinstance emits anerrorevent.Unfortunately, when testing the Studio 1.7.0 Intel build on my Apple Silicon laptop (using Rosetta emulation) none of these things appear to happen. I don't yet know what happens for regular macOS Intel users, but there are some indications that
stopAllServersdoes resolve. In any case, it's likely not working for me because the bundled node runtime initializes but can't proceed, getting stuck in an intermittent state.To mitigate against similar issues in the future, this PR adds an optional timeout to the
stopAllServersfunction that kills the child process and resolves the promise.Testing Instructions
npm startPre-merge Checklist