Fix PHP wp-config warnings when pushing site to WordPress.com #2490
+382
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pushing a site from Studio to WordPress.com, PHP warnings were generated because wp-config.php contained constant definitions that were already defined by WordPress.com's infrastructure. This fix: - Creates a sanitizeWpConfig() function that wraps define() calls with defined() checks to prevent constant redefinition warnings - Modifies DefaultExporter.addWpConfig() to sanitize wp-config.php before including it in the export archive - Adds comprehensive tests for the sanitization function Fixes: STU-1257 Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pushing a site from Studio to WordPress.com, PHP warnings were generated because wp-config.php contained constant definitions that were already defined by WordPress.com's infrastructure.
This fix:
Fixes: STU-1257
Related issues
Proposed Changes
Testing Instructions
Pre-merge Checklist