Domains: Replace Nominet-specific verification with generic custom_verifications#108555
Draft
Domains: Replace Nominet-specific verification with generic custom_verifications#108555
Conversation
…rray Replace `nominet_pending_contact_verification_request` and `nominet_domain_suspended` boolean properties with a generic `custom_verifications: string[]` array across domain type definitions, assemblers, and the Redux schema. This enables support for multiple registry-specific verification types (e.g., Nominet for .uk, KYC for .in) through a single extensible field. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Pass an optional verificationType through the mutation and API core layer so the backend can distinguish between different verification workflows (e.g., nominet vs in_kyc) when creating support tickets. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ion types Introduce a config-driven VERIFICATION_CONFIG map that renders a separate verification card per active entry in custom_verifications. Add a ContactVerificationNotice on the domain overview page to alert users when registry verification is required. Update the permission check to use the generic custom_verifications array. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… types
Render a ContactVerificationCard per entry in customVerifications
instead of checking Nominet-specific booleans. Accept a verificationType
prop to customize copy, accepted documents, and the API parameter sent
on submission. Also fix a typo in the success notice ("succcesfully"
-> "successfully").
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace nominet-specific boolean properties with the new customVerifications / custom_verifications array across all domain test fixtures and test utilities. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
After successful document submission, update the domain query cache to filter out the submitted verification key from custom_verifications. This prevents the verification notice from reappearing on the domain overview page while the backend processes the documents. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…erification Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
nominet_pending_contact_verification_requestandnominet_domain_suspendedboolean API properties with a singlecustom_verifications: string[]array across all domain type definitions, assemblers, and the Redux schema.verification_typeparameter to the domain contact verification API mutation so the backend can distinguish between different verification workflows.custom_verifications(supportsnominet_contact,nominet_suspended, andin_kyc).ContactVerificationNoticecomponent to the domain overview page to alert users when registry verification is required.verificationTypeprop for per-type copy and document customization.Why are these changes being made?
The existing domain contact verification system was hardcoded for Nominet (.uk) verification only. To support additional registry-specific verification requirements (e.g., .in domain KYC verification required by NIXI), the frontend needs a generic mechanism. By replacing the two Nominet-specific booleans with a
custom_verificationsstring array, we can support any number of verification types through a single extensible field without future type/schema changes. This is the frontend half of the work; it ships alongside a corresponding backend change that populates the new field.Testing Instructions
.ukdomains with active Nominet verification still display the correct verification card with UK-specific copy and accepted documents..indomains within_kycincustom_verificationsdisplay the correct verification card with .in-specific copy and accepted documents.custom_verificationsdo not show the verification section.custom_verificationsis non-empty.verification_typeto the API.Pre-merge Checklist