Draft
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of BSKY-1480.
For controlling the Unified Chat UI, we are now using the global custom events. However, I feel that implementing (and consuming) a get method using JavaScript’s CustomEvent() is somewhat roundabout. A more suitable approach would be to use a global variable, as shown below, for both get and set methods.
That said, during this transition period, I plan to implement these methods using the existing custom events. If you prefer the global variable approach, please feel free to let me know. The conversion should be quick with the help of AI 🤖.
Proposed Changes
Why are these changes being made?
Testing Instructions
Pre-merge Checklist