Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
p-jackson
left a comment
There was a problem hiding this comment.
Some feedback below on the column hiding logic, but otherwise good to go.
As you know, I'm not a fan of giving each of our products slightly different behaviours 😄 But I see we're already preventing this action for atomic sites, so seems fine to disable for garden sites too.
I feels the real underlying logic is probably whether the domain is *.wordpress.com or not, since we might not support updating *.wpcomstaging.com subdomains or something. But I don't know that for sure, so happy to keep the is_garden and is_wpcom_atomic checks.
| const hasEligibleActions = filteredData?.some( ( item ) => | ||
| actions.some( ( action ) => action.isEligible === undefined || action.isEligible( item ) ) | ||
| ); |
There was a problem hiding this comment.
Thanks for the fix!
I think this should use siteDomains, not filteredData. Doing the check post-filtering means that the actions column will appear and disappear as the user types in the search field, or as the user clicks between pages. I think the presence of the column should be more stable, and so it should run over all the domain data.
Remove the ability to change the default site address for CIAB sites.
Since this means there may be no "actions" to take I'm also hiding that column conditionally because it didn't look super great otherwise.
Testing
Site Overview => Domains => Action List
ARC-1408