Skip to content

CIAB: Don’t allow site address changes#108565

Open
WPprodigy wants to merge 2 commits intotrunkfrom
ciab/disable-site-address-change
Open

CIAB: Don’t allow site address changes#108565
WPprodigy wants to merge 2 commits intotrunkfrom
ciab/disable-site-address-change

Conversation

@WPprodigy
Copy link
Contributor

@WPprodigy WPprodigy commented Feb 6, 2026

Remove the ability to change the default site address for CIAB sites.

Since this means there may be no "actions" to take I'm also hiding that column conditionally because it didn't look super great otherwise.

Testing

Site Overview => Domains => Action List


ARC-1408

@WPprodigy WPprodigy requested a review from a team as a code owner February 6, 2026 19:20
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 6, 2026
@matticbot
Copy link
Contributor

matticbot commented Feb 6, 2026

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • agents-manager
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug ciab/disable-site-address-change on your sandbox.

Copy link
Member

@p-jackson p-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback below on the column hiding logic, but otherwise good to go.

As you know, I'm not a fan of giving each of our products slightly different behaviours 😄 But I see we're already preventing this action for atomic sites, so seems fine to disable for garden sites too.

I feels the real underlying logic is probably whether the domain is *.wordpress.com or not, since we might not support updating *.wpcomstaging.com subdomains or something. But I don't know that for sure, so happy to keep the is_garden and is_wpcom_atomic checks.

Comment on lines +64 to +66
const hasEligibleActions = filteredData?.some( ( item ) =>
actions.some( ( action ) => action.isEligible === undefined || action.isEligible( item ) )
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

I think this should use siteDomains, not filteredData. Doing the check post-filtering means that the actions column will appear and disappear as the user types in the search field, or as the user clicks between pages. I think the presence of the column should be more stable, and so it should run over all the domain data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants