Fix Delete Site "Manage Purchases" link to navigate to site-specific purchases#108569
Draft
Fix Delete Site "Manage Purchases" link to navigate to site-specific purchases#108569
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #CHE-145
Proposed Changes
purchasesRoot(/me/purchases) withgetPurchaseListUrlFor( siteSlug )(/purchases/subscriptions/{siteSlug}) in the Delete Site warnings componentsiteSlugprop from the parentDeleteSitecomponent (already available viagetSelectedSiteSlug) intoDeleteSiteWarningsWhy are these changes being made?
When users with active subscriptions try to delete a site, clicking "Manage purchases" takes them to
/me/purchases(all purchases across all sites). For users with multiple subscriptions, this makes it difficult to find the specific subscription they need to cancel before deleting the site.This fix updates the link to navigate to
/purchases/subscriptions/{siteSlug}, which shows only the purchases for the site being deleted. This matches the existing pattern used in the Dashboard site delete modal and the Leave Site flow.Testing Instructions
/sites/settings/site/{site-slug}/delete-site)/purchases/subscriptions/{site-slug}(site-specific purchases)/me/purchases(all purchases)Also test the trial site flow:
Pre-merge Checklist