Fix TypeError in notifications when note has no actions#108577
Draft
StevenDufresne wants to merge 1 commit intotrunkfrom
Draft
Fix TypeError in notifications when note has no actions#108577StevenDufresne wants to merge 1 commit intotrunkfrom
StevenDufresne wants to merge 1 commit intotrunkfrom
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
8bb5b7b to
7a580ce
Compare
7a580ce to
4ad040c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CALYPSO-2HCW
Proposed Changes
hasActionhelper within bothbody.tsxandbody.jsxto handle whengetActions()returnsundefinedWhy are these changes being made?
#108325 introduced code in
body.tsxandbody.jsxthat callsgetActions(note)and then immediately calls.hasOwnProperty()on the result. When a notification has no action blocks,getActions()returnsundefined, causing a TypeError tracked as CALYPSO-2HCW.The fix adds a null guard in the
hasActionhelper in both files — the same files where the bug was introduced.Testing Instructions
Pre-merge Checklist