Remove Password component from onboarding flow#38
Open
Avi-ADAM wants to merge 1 commit into
Open
Conversation
- bein.svelte: add `mode !== 'onboarding'` guard to the step-5 render
block so Password can never flash on screen in onboarding mode, even
if the shared `show` store carries a stale value of 5. The existing
$effect redirect and the onMount guard in manual/+page.svelte already
cover this, but the template guard is the definitive safety net.
- beinang.svelte: remove the dead `import Password` and its
corresponding `{:else if show_value == 5}` render block. beinang is
not imported anywhere in the codebase so this is pure cleanup.
https://claude.ai/code/session_01NzH5UyFVDXK2ReMm8pT1J9
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bein.svelte: add
mode !== 'onboarding'guard to the step-5 renderblock so Password can never flash on screen in onboarding mode, even
if the shared
showstore carries a stale value of 5. The existing$effect redirect and the onMount guard in manual/+page.svelte already
cover this, but the template guard is the definitive safety net.
beinang.svelte: remove the dead
import Passwordand itscorresponding
{:else if show_value == 5}render block. beinang isnot imported anywhere in the codebase so this is pure cleanup.
https://claude.ai/code/session_01NzH5UyFVDXK2ReMm8pT1J9