Open
Conversation
…pse-admin into matrix-oauth-flow
Member
|
It's a bit too much for a single PR. Please try to move self contained stuff, like changing the router, into a separate PR. Also please don't merge master, instead use rebase. |
awesome-manuel
force-pushed
the
master
branch
6 times, most recently
from
4624efc to
e6228d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello. I'm new to matrix and the ecosystem so I'm not certain all of my changes are up to standards, but it seems to work.
I was trying to use this for my matrix instance, but it kept incorrectly saying I didn't have admin access. After some digging I realised it was due to my setup utilising the new(?) Matrix Authentication Service, which meant that the access token the old auth flow returned was a basic user token.
So, what I've done:
I've tested this against my own instance, however, since I run MAS, I've not been able to verify this against a setup that doesn't, though I've tried to keep the old flow in place.