[Docker] Enforce container security#812
Open
DodoLeDev wants to merge 1 commit intoAwesome-Technologies:masterfrom
Open
[Docker] Enforce container security#812DodoLeDev wants to merge 1 commit intoAwesome-Technologies:masterfrom
DodoLeDev wants to merge 1 commit intoAwesome-Technologies:masterfrom
Conversation
The container now works completely unprivileged
| COPY --from=builder /src/dist /app | ||
|
|
||
| # Delete useless files. We need to temporarily escalate to root user for this task | ||
| USER 0 |
Member
There was a problem hiding this comment.
We might as well move everything from /app to /usr/share/nginx/html to avoid UID switch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I am trying to use your application through containers, and I found out that it defaults to root user while not being necessary.
Here are the necessary edits to make your app working completely unprivileged