feat(Footer): add aria-expended and aria-controls on mobile button menu links (#1219)#1352
Open
gaouimounir wants to merge 1 commit intoAxaFrance:mainfrom
Open
feat(Footer): add aria-expended and aria-controls on mobile button menu links (#1219)#1352gaouimounir wants to merge 1 commit intoAxaFrance:mainfrom
gaouimounir wants to merge 1 commit intoAxaFrance:mainfrom
Conversation
arnaudforaison
approved these changes
Jul 21, 2025
Contributor
|
can you please add a |
Contributor
|
@gaouimounir @arnaudforaison on garde la PR ? Faudrait la passer sur canopee |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used aria-expanded to reflect the current state of the menu (open or closed)
Implemented aria-controls on the button to reference the menu
, with a dynamically generated unique ID using useId()