[Slash] Field - Ajout de la classe af-form_group meme lors d'une surcharge de className#1370
Open
arnaudforaison wants to merge 1 commit intomainfrom
Open
[Slash] Field - Ajout de la classe af-form_group meme lors d'une surcharge de className#1370arnaudforaison wants to merge 1 commit intomainfrom
arnaudforaison wants to merge 1 commit intomainfrom
Conversation
MartinWeb
reviewed
Jul 31, 2025
| isVisible?: boolean; | ||
| roleContainer?: string; | ||
| ariaLabelContainer?: string; | ||
| isLabelContainerLinkedToInput?: boolean; |
Contributor
There was a problem hiding this comment.
cette props là n'était pas utilisable par les consommateurs ?
Contributor
Author
There was a problem hiding this comment.
J'ai trouvé aucun consommateur et en plus elle n'a pas de sens. Car elle est utilisée pour lié le label avec l'input sur le htmlFor, or c'est toujours le cas
Contributor
There was a problem hiding this comment.
il me semble qu'il y avait des cas où on ne liait pas le label avec l'input, dans le cas des radio je crois
pplancq
reviewed
Jul 31, 2025
Comment on lines
+151
to
154
| className={classNames(className, "row", groupClassName, { | ||
| "af-form__group--required": actualRequired, | ||
| "af-form__group--label-top": labelPosition === "top", | ||
| })} |
Contributor
There was a problem hiding this comment.
Suggested change
| className={classNames(className, "row", groupClassName, { | |
| "af-form__group--required": actualRequired, | |
| "af-form__group--label-top": labelPosition === "top", | |
| })} | |
| className={classNames("row", groupClassName, { | |
| "af-form__group--required": actualRequired, | |
| "af-form__group--label-top": labelPosition === "top", | |
| }, className)} |
les class css de utilisateur doivent toujours être placé à la fin affin qu'elle soit en surcharge du css si besoin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Si on surcharge notre Input (par ex: RadioInput) avec une className alors la class
af-form_groupétait supprimée.La PR permet de garder les 2 classes
af-form_groupet la surcharge de className par le consommateur