Remove stale userInfo data on logout when using Service Worker#1638
Draft
mteterel wants to merge 3 commits intoAxaFrance:mainfrom
Draft
Remove stale userInfo data on logout when using Service Worker#1638mteterel wants to merge 3 commits intoAxaFrance:mainfrom
mteterel wants to merge 3 commits intoAxaFrance:mainfrom
Conversation
This is a follow-up of the fix I pushed in AxaFrance#1603. The initial fix only worked in a non-SW scenario, the issue is still present otherwise.
Contributor
|
Thank you for your contribution :) Tell me @mteterel when you will be ready for some feedbacks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up of the fix I proposed in #1603. The fix only covered non-SW scenarios so the issue is still present as of today otherwise.
As a reminder, the issue is that when switching accounts, userInfo from the first account was stored and reloaded as-is, leading the various hooks to return stale data. Token behavior however works as expected.