Merged
Conversation
feat: introduce Test-Driven Development (TDD) skill documentation feat: create Testing Anti-Patterns reference for better test practices feat: establish Writing Plans skill for comprehensive implementation planning feat: add Plan Document Reviewer Prompt Template for plan verification feat: link new skills in Claude for easier access to testing and planning resources chore: update skills-lock.json to include new skills and their sources
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b872ccd95
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds several new “skills” (agent prompt/reference documents) to support development workflows (planning, code review, CI, testing, Terraform, PostgreSQL) and registers them in the repo’s skills-lock.json.
Changes:
- Add multiple new skill documents under
.agents/skills/*(new prompts, guides, and references). - Add a new TDD anti-patterns reference and a plan-document reviewer dispatch template.
- Update
skills-lock.jsonto include the newly added skills and their hashes/sources.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| skills-lock.json | Registers the newly added skills with source + computed hash. |
| .agents/skills/writing-plans/plan-document-reviewer-prompt.md | Adds a reusable prompt template for reviewing plan documents. |
| .agents/skills/writing-plans/SKILL.md | Adds a “writing plans” skill guide and required plan/task structure. |
| .agents/skills/test-driven-development/testing-anti-patterns.md | Adds a reference doc of common testing anti-patterns and fixes. |
| .agents/skills/test-driven-development/SKILL.md | Adds a full TDD skill guide (red/green/refactor, checklists, rationale). |
| .agents/skills/terraform-test/references/MOCK_PROVIDERS.md | Adds reference documentation for Terraform mock providers. |
| .agents/skills/terraform-test/references/EXAMPLES.md | Adds example Terraform test suites (unit/integration/mock). |
| .agents/skills/terraform-test/references/CI_CD.md | Adds CI/CD examples for running Terraform tests in GitHub Actions/GitLab CI. |
| .agents/skills/terraform-test/SKILL.md | Adds the main Terraform test skill guide and patterns. |
| .agents/skills/terraform-style-guide/SKILL.md | Adds a Terraform style guide skill based on HashiCorp conventions. |
| .agents/skills/requesting-code-review/code-reviewer.md | Adds a template for dispatching a code-reviewer subagent. |
| .agents/skills/requesting-code-review/SKILL.md | Adds guidance for when/how to request code review via subagent. |
| .agents/skills/postgresql-table-design/SKILL.md | Adds PostgreSQL schema/table design best practices and patterns. |
| .agents/skills/github-actions-templates/SKILL.md | Adds GitHub Actions workflow templates/patterns and best practices. |
| .agents/skills/e2e-testing-patterns/SKILL.md | Adds E2E testing patterns (Playwright/Cypress) and reliability guidance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces three new skill documentation files for the agent system, each providing comprehensive guides and best practices for key engineering workflows. The additions are aimed at improving developer productivity, code quality, and database design standards. The most important changes are summarized below:
New Skill Documentation:
GitHub Actions Workflow Templates:
.agents/skills/github-actions-templates/SKILL.md, a detailed guide for creating production-ready GitHub Actions workflows. It includes common patterns for CI/CD, Docker builds, Kubernetes deployment, matrix builds, security scanning, and best practices for workflow design and security.PostgreSQL Table Design:
.agents/skills/postgresql-table-design/SKILL.md, an extensive resource on PostgreSQL schema design. Covers data types, indexing, constraints, partitioning, performance, schema evolution, and advanced features/extensions, with practical examples and anti-patterns to avoid.Requesting Code Review:
.agents/skills/requesting-code-review/SKILL.md, a practical guide for requesting and integrating code reviews within agent-driven development workflows. Outlines when and how to request reviews, how to act on feedback, and includes integration tips and red flags to avoid.