[DRAFT] [BREAKING] FEAT Dedicated Scenario Dataset Loading Features#1191
Closed
ValbuenaVC wants to merge 4 commits intoAzure:mainfrom
Closed
[DRAFT] [BREAKING] FEAT Dedicated Scenario Dataset Loading Features#1191ValbuenaVC wants to merge 4 commits intoAzure:mainfrom
ValbuenaVC wants to merge 4 commits intoAzure:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moving dataset loading responsibilities to a dedicated ScenarioDatasetLoader class. Accomplishes a few things:
initialize_asyncis called, which in turn calls .load() for the loader)Seed,SeedPrompt,SeedGroup, etc.)The new design is meant to decouple as much of the prompt management as possible, so that a Scenario subclass can have a rich custom attack construction if desired, or just use a default SeedGroup if not
Tests and Documentation
TBD