Change default parallelism of Storage SDK#7190
Open
Jinming-Hu wants to merge 1 commit into
Open
Conversation
Jinming-Hu
requested review from
LarryOsterman,
amnguye,
antkmsft and
gapra-msft
as code owners
14 tasks
Member
Author
|
@amnguye @gapra-msft can you please help approve this PR? |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Storage SDK’s default parallel transfer concurrency to be hardware-aware by introducing a shared helper in azure-storage-common, and applies the new default across Blobs, Files Shares, and DataLake option types.
Changes:
- Added
Azure::Storage::_internal::GetHardwareConcurrency()inazure-storage-commonand wired it into the build. - Updated default
TransferOptions.Concurrencyinitializers in Blobs/Shares/DataLake option headers to use hardware concurrency (with clamping). - Documented the change in each package’s
CHANGELOG.md.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/storage/azure-storage-files-shares/inc/azure/storage/files/shares/share_options.hpp | Updates default transfer concurrency for share upload/download option types. |
| sdk/storage/azure-storage-files-shares/CHANGELOG.md | Notes updated default concurrency settings in the upcoming release section. |
| sdk/storage/azure-storage-files-datalake/inc/azure/storage/files/datalake/datalake_options.hpp | Updates default transfer concurrency for DataLake upload option type. |
| sdk/storage/azure-storage-files-datalake/CHANGELOG.md | Notes updated default concurrency settings in the upcoming release section. |
| sdk/storage/azure-storage-common/src/concurrent_transfer.cpp | Adds implementation of GetHardwareConcurrency(). |
| sdk/storage/azure-storage-common/inc/azure/storage/common/internal/concurrent_transfer.hpp | Declares GetHardwareConcurrency() for reuse by other storage components. |
| sdk/storage/azure-storage-common/CMakeLists.txt | Adds the new concurrent_transfer.cpp source file to the common library target. |
| sdk/storage/azure-storage-blobs/inc/azure/storage/blobs/blob_options.hpp | Updates default transfer concurrency for blob upload/download option types. |
| sdk/storage/azure-storage-blobs/CHANGELOG.md | Notes updated default concurrency settings in the upcoming release section. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #7007
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.