interface: support BYO resource group for atm#251
interface: support BYO resource group for atm#251zhiying-lin wants to merge 1 commit intoAzure:mainfrom
Conversation
| // The Azure Resource Group of the existing resource. | ||
| // +required | ||
| // +kubebuilder:validation:XValidation:rule="self == oldSelf",message="resourceGroup is immutable" | ||
| ResourceGroup string `json:"resourceGroup"` |
There was a problem hiding this comment.
we could add name in the future to support BYO ATM profile.
| type TrafficManagerProfileSpec struct { | ||
| // BringYourOwn defines the Azure Traffic Manager in your own resource group. | ||
| // +required | ||
| BringYourOwn *BringYourOwn `json:"bringYourOwn"` |
There was a problem hiding this comment.
Just ResourceGroup? The bring your own noun is unnecessary, as there is no not bring your now today.
// The resource ID of the resource group to contain the Azure Traffic Manager resource corresponding to this profile. Use this option if you would like to use this profile to manage the full life cycle of the traffic manager, including creation and deletion. When this profile is created, updated, or deleted, the corresponding traffic manager with the same name will be created, updated, or deleted.
Later, we can add:
// The resource ID of the Azure Traffic Manager resource corresponding to this profile. Use this option if you would like to use this profile to update an existing traffic manager, not creating or deleting it.
ResourceId;
// If none of the above is specified, we will use the default resource group passed in as an env variable.
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
Three options to support BYO rg
Which issue(s) this PR fixes:
Fixes #
Requirements:
make reviewablefor basic local testHow has this code been tested
Special notes for your reviewer