Skip to content

Fixed rendering error in the 'On Transcript' column for StudentStaff#1723

Merged
MImran2002 merged 5 commits into
developmentfrom
julius_zhytkov_1441
Jun 17, 2026
Merged

Fixed rendering error in the 'On Transcript' column for StudentStaff#1723
MImran2002 merged 5 commits into
developmentfrom
julius_zhytkov_1441

Conversation

@zhytkovd

@zhytkovd zhytkovd commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Issue Description

Fixes #1441

  • The table wasn't displaying the buttons in the "On Transcript" column for the student staff; however, it still showed the header and caused the missing space.
  • For all the other types of users, it was displaying information correctly.

Changes

  • We revoked access to the student staff to see the transcript buttons.
  • Transcript buttons are only viewable to staff and admins.

Testing

  • Checked that it's working with every single user and checked that the buttons were working correctly in each case.

Copilot AI review requested due to automatic review settings June 16, 2026 17:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the user profile “Programs” table so CELTS Student Staff can see the “On Transcript” controls, matching what CELTS Admins already see and fixing the missing/incorrect rendering for that role.

Changes:

  • Expand the “On Transcript” column rendering condition to include g.current_user.isCeltsStudentStaff.
Comments suppressed due to low confidence (1)

app/templates/main/userProfile.html:251

  • This if condition duplicates the parent block condition ({% if g.current_user.isCeltsAdmin or g.current_user.isCeltsStudentStaff %} a few lines above), so it no longer provides any additional gating and adds unnecessary nesting. Consider removing this inner {% if %} / {% endif %} and always rendering the <td> within the already-guarded section.
                    {% if g.current_user.isCeltsAdmin or g.current_user.isCeltsStudentStaff %}
                        <td class="onTranscript">
                          <input class="form-check-input onTranscriptCheckbox ms-5" name="onTranscriptCheckbox" id="onTranscriptCheckbox" type="checkbox" data-programid="{{row.program.id}}"
                          data-username="{{volunteer.username}}" {% if row.isNotBanned %}checked disabled{% endif %} {% if row.onTranscript %} checked {% endif %}/>
                          <div id="transcriptStatus-{{row.program.id}}" class="transcriptStatus"></div>

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MImran2002 MImran2002 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be talked with Brian on whether we will allow isStudentAdmin to have access to this feature or not

Copilot AI review requested due to automatic review settings June 16, 2026 20:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread app/templates/main/userProfile.html
@github-actions

Copy link
Copy Markdown

View Code Coverage

@MImran2002

Copy link
Copy Markdown
Contributor

ontranscript doesn't show up when user is isstudent, isstudentstaff. Seems good!

@MImran2002 MImran2002 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ontranscript doesn't show up when user is isstudent, isstudentstaff. Seems good!

@MImran2002 MImran2002 merged commit f511c4c into development Jun 17, 2026
5 checks passed
munsakad pushed a commit that referenced this pull request Jun 17, 2026
…_1441

Fixed rendering error in the 'On Transcript' column for StudentStaff the issue description is changed as CELTS do not want isStudentStaff to see.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table under Programs on User Profile is not properly filling the page

3 participants