Fixed rendering error in the 'On Transcript' column for StudentStaff#1723
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the user profile “Programs” table so CELTS Student Staff can see the “On Transcript” controls, matching what CELTS Admins already see and fixing the missing/incorrect rendering for that role.
Changes:
- Expand the “On Transcript” column rendering condition to include
g.current_user.isCeltsStudentStaff.
Comments suppressed due to low confidence (1)
app/templates/main/userProfile.html:251
- This
ifcondition duplicates the parent block condition ({% if g.current_user.isCeltsAdmin or g.current_user.isCeltsStudentStaff %}a few lines above), so it no longer provides any additional gating and adds unnecessary nesting. Consider removing this inner{% if %}/{% endif %}and always rendering the<td>within the already-guarded section.
{% if g.current_user.isCeltsAdmin or g.current_user.isCeltsStudentStaff %}
<td class="onTranscript">
<input class="form-check-input onTranscriptCheckbox ms-5" name="onTranscriptCheckbox" id="onTranscriptCheckbox" type="checkbox" data-programid="{{row.program.id}}"
data-username="{{volunteer.username}}" {% if row.isNotBanned %}checked disabled{% endif %} {% if row.onTranscript %} checked {% endif %}/>
<div id="transcriptStatus-{{row.program.id}}" class="transcriptStatus"></div>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MImran2002
requested changes
Jun 16, 2026
MImran2002
left a comment
Contributor
There was a problem hiding this comment.
This should be talked with Brian on whether we will allow isStudentAdmin to have access to this feature or not
Contributor
|
ontranscript doesn't show up when user is isstudent, isstudentstaff. Seems good! |
MImran2002
approved these changes
Jun 17, 2026
MImran2002
left a comment
Contributor
There was a problem hiding this comment.
ontranscript doesn't show up when user is isstudent, isstudentstaff. Seems good!
munsakad
pushed a commit
that referenced
this pull request
Jun 17, 2026
…_1441 Fixed rendering error in the 'On Transcript' column for StudentStaff the issue description is changed as CELTS do not want isStudentStaff to see.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Description
Fixes #1441
Changes
Testing