-
Notifications
You must be signed in to change notification settings - Fork 13
exception handling in slcManagement.js #1727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
munsakad
wants to merge
23
commits into
development
Choose a base branch
from
feitsopb_dee_exceptionhandling
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5
−7
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
f038336
Merge pull request #1720 from BCStudentSoftwareDevTeam/Bhushan&Artem
BrianRamsay 0ed7a1e
scaling issues on buttons on course proposals is fixed
munsakad 53ac15d
Merge branch 'development' into bright_and_dee-course_proposal_button…
munsakad a0a2d27
Ignore SSL connection to mysql in devcontainer
BrianRamsay a3f03d4
Fixed buttons and scaling at the bottom of all three pages, including…
munsakad 19e3d99
Merge branch 'development' into bright_and_dee-course_proposal_button…
MImran2002 defc0bb
Revert changes to emergencyContactInfo and insuranceInfo
munsakad 7f62397
Move page indicator below buttons so right buttons never go under dots
munsakad 60f10ef
Fix button scaling and layout on emergencyContactInfo and insuranceInfo
munsakad 885d5b1
Add user-facing error handling to withdraw ajax request
munsakad 664991a
Revert unrelated files from exception handling branch
d1551aa
Use flash message for withdraw errors
e89ec90
Merge branch 'development' into feitsopb_dee_exceptionhandling
MImran2002 a2cddad
Merge branch 'development' into feitsopb_dee_exceptionhandling
5c6b519
Display withdraw error message inside modal instead of page flash
munsakad 28154c3
Merge branch 'feitsopb_dee_exceptionhandling' of https://github.com/B…
ab6b6fc
Use flash message for SLC withdraw errors
c49016e
Merge branch 'development' into feitsopb_dee_exceptionhandling
MImran2002 d605519
Handle SLC withdraw response status
acfc5a7
Reload SLC management after withdraw error
042bc0c
resolved the suggestions
8be7e05
resolved comment R200
0d75745
removed complete function from line 145 in slcManagemnet.js
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we are adding server codes return "", 500 should be nested in the exception or else and internal server outside of the exception doesn't make sense for me if exception is catching the errors. What do you think @BrianRamsay ? Should the other catches also consider 200 and 403?