Slider UI fix: pointer inputs not adjusted for adaptive scaling#17968
Slider UI fix: pointer inputs not adjusted for adaptive scaling#17968sebavan merged 1 commit intoBabylonJS:masterfrom
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17968/merge/index.html#WGZLGJ#4600 Links to test your changes to core in the published versions of the Babylon tools (does not contain changes you made to the tools themselves): https://playground.babylonjs.com/?snapshot=refs/pull/17968/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17968/merge#BCU1XR#0 If you made changes to the sandbox or playground in this PR, additional comments will be generated soon containing links to the dev versions of those tools. |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
RaananW
left a comment
There was a problem hiding this comment.
Just for me to understand, the only change here is running the code even if the component's is 0, right?
|
@marns, any repro of the bug it creates ? |
|
@RaananW right @sebavan and after: Here you can see input is mapped to the middle 25% of the rendered slider |
With adaptive scaling active, transformCoordinates is required to bring pointer inputs into the correct slider space. Otherwise input pointer may be significantly off / remapped from visuals.
Fix: always transform pointer coordinates