Viewer: Enable test for IBL shadows#17986
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enables a previously commented-out test for the IBL (Image-Based Lighting) shadows feature in the Viewer. The test was disabled due to WebGPU-related bugs that have now been resolved in PR #17976. The test verifies that the shadow-quality="high" attribute works without producing WebGPU console errors or page errors.
Changes:
- Uncommented and enabled the
shadow-quality="high"test case that validates IBL shadows functionality
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17986/merge/index.html#WGZLGJ#4600 Links to test your changes to core in the published versions of the Babylon tools (does not contain changes you made to the tools themselves): https://playground.babylonjs.com/?snapshot=refs/pull/17986/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17986/merge#BCU1XR#0 If you made changes to the sandbox or playground in this PR, additional comments will be generated soon containing links to the dev versions of those tools. |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
Pull request was converted to draft
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
Now that the last of the known issues with IBL shadows + WebGPU is fixed, enabling the IBL shadows test for the Viewer. This is not a visual test that actually compares screenshots at this point, it only looks for WebGPU errors in the console, which so far have always been present in the issues that have cropped up.
UPDATE: This revealed a couple additional IBL shadow related bugs due to different gpu limits on the build agents. Fixes for these issues are included in this PR. @MiiBond