Inspector v2: Types support in Playground#17993
Inspector v2: Types support in Playground#17993ryantrem wants to merge 1 commit intoBabylonJS:masterfrom
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17993/merge/index.html#WGZLGJ#4600 Links to test your changes to core in the published versions of the Babylon tools (does not contain changes you made to the tools themselves): https://playground.babylonjs.com/?snapshot=refs/pull/17993/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17993/merge#BCU1XR#0 If you made changes to the sandbox or playground in this PR, additional comments will be generated soon containing links to the dev versions of those tools. |
|
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/17993/merge/ |
|
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17993/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
There was a problem hiding this comment.
Pull request overview
Adds Inspector v2 TypeScript typings to the Playground’s Monaco editor so users get type support when using Inspector v2, and simplifies local dev tasks now that Playground/Sandbox consume Inspector v2 from the UMD build.
Changes:
- Add
babylon.inspector-v2.d.tsto Monaco’s fetched declaration list. - Remove the
Watch Inspector v2dependency from the VS Code “Playground Serve (Dev)” and “Sandbox Serve (Dev)” tasks.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/tools/playground/src/tools/monaco/monacoManager.ts | Adds Inspector v2 declaration URL to Monaco typings preload list. |
| .vscode/tasks.json | Removes Inspector v2 watch task dependency from Playground/Sandbox serve tasks. |
|
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/17993/merge/ |
|
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17993/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
Adding the Inspector v2 umd d.ts to the list for the Monaco editor in Playground.
Also removing the now unneeded VS code task dependency for Playground/Sandbox on the Inspector v2 watch task since Inspector v2 is now consumed from umd in Playground/Sandbox.