Skip to content

Animation Retargeting: Fix regression in #17994#17996

Open
Popov72 wants to merge 2 commits intoBabylonJS:masterfrom
Popov72:fix-animretarget-regression
Open

Animation Retargeting: Fix regression in #17994#17996
Popov72 wants to merge 2 commits intoBabylonJS:masterfrom
Popov72:fix-animretarget-regression

Conversation

@Popov72
Copy link
Contributor

@Popov72 Popov72 commented Feb 28, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 28, 2026 14:25
@bjsplat
Copy link
Collaborator

bjsplat commented Feb 28, 2026

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a regression in animation retargeting by improving state restoration and targeted animation handling in the core AnimatorAvatar retargeting pipeline.

Changes:

  • Track and restore additional transform-node rotation state during retargeting reset.
  • Ensure missing-bone targeted animations are removed regardless of warning settings.
  • Reset skeletons to rest pose before preparing bone world matrices.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 28, 2026

Snapshot stored with reference name:
refs/pull/17996/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17996/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17996/merge/index.html#WGZLGJ#4600

Links to test your changes to core in the published versions of the Babylon tools (does not contain changes you made to the tools themselves):

https://playground.babylonjs.com/?snapshot=refs/pull/17996/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/17996/merge
https://gui.babylonjs.com/?snapshot=refs/pull/17996/merge
https://nme.babylonjs.com/?snapshot=refs/pull/17996/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/17996/merge#BCU1XR#0

If you made changes to the sandbox or playground in this PR, additional comments will be generated soon containing links to the dev versions of those tools.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 28, 2026

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 28, 2026

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 28, 2026

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 28, 2026

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 28, 2026

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 28, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants