Symfony 6 7 8 php 8 3#24
Closed
alexver wants to merge 9 commits into
Closed
Conversation
Extend the compatibility range so the bundle stops capping downstream consumers at Symfony 6.x, while keeping 6.4 in range (no core upgrade). - composer: symfony/* => ^6.4 || ^7.0 || ^8.0, php => >=8.3 - composer: phpunit/phpunit => ^11.5 || ^12.0 - tests: replace removed MockBuilder::setMethods()/addMethods() with a mock of the concrete ExpressAuthorizeRequest (onlyMethods) - phpunit.xml.dist: migrate removed <filter><whitelist> to <source> - fix PHP 8 typed-property regressions so the suite passes (Service transaction guard via isset(), nullable amount, empty response => null) Verified resolvable on 6.4 and 7.x; suite green on Symfony 6.4 + PHPUnit 12. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
garak
requested changes
Jun 12, 2026
| ->cannotBeEmpty() | ||
| ->defaultValue('Beelab\PaypalBundle\Paypal\Service') | ||
| ->setDeprecated('The "service_class" option is deprecated. Define your class as service instead.') | ||
| ->setDeprecated('The "service_class" option is deprecated. Define your class as service instead.', '') |
Member
There was a problem hiding this comment.
What's the point of this empty string?
|
|
||
| namespace Beelab\PaypalBundle\Entity; | ||
|
|
||
| use DateTime; |
| { | ||
| return $this->response; | ||
| $result = $this->response; | ||
| if (empty($result) && $this->responseText != '') { |
Member
There was a problem hiding this comment.
empty should be avoided, use a proper check
| $this->status = self::STATUS_OK; | ||
| $this->end = new \DateTime(); | ||
| $this->response = $response; | ||
| $this->response = $response??[]; |
| $this->status = self::STATUS_ERROR; | ||
| $this->end = new \DateTime(); | ||
| $this->response = $response; | ||
| $this->response = $response??[]; |
| @@ -1,4 +1,5 @@ | |||
| .*.cache | |||
| .idea | |||
Member
There was a problem hiding this comment.
this is a big no-no. Use your global ignore for local files
| @@ -0,0 +1,41 @@ | |||
| # CLAUDE.md | |||
| "require": { | ||
| "php": "^7.1", | ||
| "doctrine/orm": "^2.5", | ||
| "php": ">=8.3", |
Member
There was a problem hiding this comment.
this is too loose, we can't guarantee this bundle will work on PHP 9+
| "omnipay/common": "^3.0", | ||
| "php-http/guzzle6-adapter": "^2.0", | ||
| "phpunit/phpunit": "^7.5 || ^8.5 || ^9.1" | ||
| "phpunit/phpunit": "^11.5 || ^12.0" |
| <phpunit bootstrap="./Tests/bootstrap.php" colors="true"> | ||
| <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd" | ||
| bootstrap="./Tests/bootstrap.php" |
Member
There was a problem hiding this comment.
we don't need the bootstrap file anymore
Member
|
No activity here, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symfony 6/7/8 compatible
Fix #21 and #23