feat(sdk-core): add EdDSA MPCv2 offline signing helper utils#8793
Open
vibhavgo wants to merge 1 commit into
Open
feat(sdk-core): add EdDSA MPCv2 offline signing helper utils#8793vibhavgo wants to merge 1 commit into
vibhavgo wants to merge 1 commit into
Conversation
vibhavgo
changed the title
vibhavgo
changed the title
Ticket: WCI-386 Adds shared private utility methods to EddsaMPCv2Utils that will be used across all three createOfflineRound1/2/3Share methods. These are prerequisite helpers that centralize transaction payload extraction, GPG key handling, and authenticated data validation to prevent code duplication. - Add MPS_DSG_SIGNING_USER_GPG_KEY domain-separator constant for adata prefixes - Add getSignableHexAndDerivationPath() to extract signableHex and derivationPath from txRequest - Add getBitgoAndUserGpgKeys() to decrypt user GPG keys with v1 (SJCL) and v2 (Argon2id) envelope support - Add validateAdata() to validate authenticated data matches cyphertext adata - Import isV2Envelope from baseTypes for envelope version detection - Add comprehensive test coverage for all three helper methods
vibhavgo
force-pushed
the
WCI-386/eddsa-util-helper
branch
from
73179bb to
f4ebbae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds shared private utility methods to EddsaMPCv2Utils that will be used across all three createOfflineRound1/2/3Share methods. These are prerequisite helpers that centralize transaction payload extraction, GPG key handling, and authenticated data validation to prevent code duplication.
Ticket: WCI-386