test: expand helper-module and SSH parsing coverage#6
Merged
UptimeEnforcer merged 2 commits intoBlack-HOST:mainfrom Mar 13, 2026
Merged
Conversation
Member
|
@zeroth-blip I'm merging this. In checkip.t, a very clean data-driven loop (assert_cases(&checkip, [ ... ])) is used for testing variations of IPs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR expands the unit-test suite with focused coverage for helper modules and SSH-related parsing paths.
Added coverage for
ConfigServer::GetEthDevConfigServer::LoggerConfigServer::LookupIPConfigServer::ServiceConfigServer::KillSSHConfigServer::regexmainWhy this change
These areas are heavy on parsing, environment-dependent behavior, and guard logic, which makes them good candidates for focused regression coverage.
The new tests aim to:
What is included
KillSSHbehavior coverageregexmaincoverage for SSH failure/accept flows and gating logicWhat is not included
Validation
Ran locally and passed:
Result:
PASSCommits
test: expand unit coverage for helper modulestest: add killssh and regexmain coverage