Skip to content

Use proper http client #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prplwtf merged 2 commits into from
May 13, 2026
+9 −17
Merged

Use proper http client #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0706a6f
feat: use proper http client for bp:meta command
prplwtf May 13, 2026
14c432e
feat: use proper http client for bp:version:cache command
prplwtf May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions app/Console/Commands/BlueprintFramework/MetadataCacheCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

use Illuminate\Console\Command;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Http;
use Pterodactyl\Models\ExtensionCachedMetadata;
use Pterodactyl\BlueprintFramework\Services\PlaceholderService\BlueprintPlaceholderService;
use Pterodactyl\BlueprintFramework\Libraries\ExtensionLibrary\Console\BlueprintConsoleLibrary as BlueprintExtensionLibrary;
Expand Down Expand Up @@ -41,12 +42,8 @@ public function handle()
$installedExtensions = $this->blueprint->extensions();

// get version info
$context = stream_context_create(['http' => ['method' => 'GET', 'header' => 'User-Agent: BlueprintFramework']]);
$remoteVersions = @file_get_contents(
$this->PlaceholderService->api_url() . '/api/extensions/latest',
false,
$context
);
$res = Http::get($this->PlaceholderService->api_url() . '/api/extensions/latest');
$remoteVersions = $res->body();

if($remoteVersions) {
$remoteVersionsData = json_decode($remoteVersions, true);
Expand Down
17 changes: 6 additions & 11 deletions app/Console/Commands/BlueprintFramework/Version/VersionCacheCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
namespace Pterodactyl\Console\Commands\BlueprintFramework\Version;

use Illuminate\Console\Command;
use Illuminate\Support\Facades\Http;
use Pterodactyl\BlueprintFramework\Services\PlaceholderService\BlueprintPlaceholderService;
use Pterodactyl\BlueprintFramework\Libraries\ExtensionLibrary\Console\BlueprintConsoleLibrary as BlueprintExtensionLibrary;

Expand All @@ -20,22 +21,16 @@ public function __construct(

public function handle()
{
$api_url = $this->PlaceholderService->api_url() . '/api/latest';
$context = stream_context_create([
'http' => [
'method' => 'GET',
'header' => 'User-Agent: BlueprintFramework',
],
]);
$response = @file_get_contents($api_url, false, $context);
$res = Http::get($this->PlaceholderService->api_url() . '/api/latest');
$body = $res->body();

if ($response === false || empty($response)) {
if ($body === false || empty($body)) {
$this->blueprint->dbSet('blueprint', 'internal:version:latest', 'unknown');
return false;
}

if ($response) {
$cleaned_response = preg_replace('/[[:^print:]]/', '', $response);
if ($body) {
$cleaned_response = preg_replace('/[[:^print:]]/', '', $body);
$data = json_decode($cleaned_response, true);
if (isset($data['name'])) {
$latest_version = $data['name'];
Expand Down
Loading