Add *args and **kwargs to base generic actor class perform() method#837
Merged
LincolnPuzey merged 2 commits intoBogdanp:masterfrom Feb 17, 2026
Merged
Add *args and **kwargs to base generic actor class perform() method#837LincolnPuzey merged 2 commits intoBogdanp:masterfrom
LincolnPuzey merged 2 commits intoBogdanp:masterfrom
Conversation
…entation This means that when a generic Actor missing perform() is called with args, the correct NotImplementedError is raised, and also reduces mypy errors in code implemented generic actors.
Contributor
|
Oh I was literally just about to click Approve when you merged! 🤓 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures the correct
NotImplementedErroris raised when called with args.Shouldn't effect real code using this, since they should implement their own
perform()method,meaning this code is never actually called.
Closes #805