spell haste

.gitignore

@@ -11,6 +11,9 @@
 # IntelliJ settings
 .idea/
 
+# vscode settings
+.vscode/
+
 #This is used for the atom build package, enables the build to happen on each save.
 .atom-build.yml
 

.luacheckrc

@@ -347,6 +347,8 @@ stds.ecs = {
         "C_Debug.TeleportToMapLocation",
         "C_Engraving",
         "C_Engraving.GetRuneForEquipmentSlot",
+        "C_EventUtils",
+        "C_EventUtils.IsEventValid",
         "C_FriendList.AddFriend",
         "C_FriendList.AddIgnore",
         "C_FriendList.AddOrDelIgnore",
@@ -563,6 +565,8 @@ stds.ecs = {
         "C_UnitAuras",
         "C_UnitAuras.GetAuraDataByIndex",
         "C_UnitAuras.GetBuffDataByIndex",
+        "C_UnitAuras.GetDebuffDataByIndex",
+        "C_UnitAuras.GetPlayerAuraBySpellID",
         "C_VideoOptions.GetGxAdapterInfo",
         "C_VoiceChat.ActivateChannel",
         "C_VoiceChat.BeginLocalCapture",
@@ -1742,6 +1746,7 @@ stds.ecs = {
         "KBSystem_GetServerNotice",
         "KBSystem_GetServerStatus",
         "LE_EXPANSION_BURNING_CRUSADE",
+        "LE_UNIT_STAT_SPIRIT",
         "LearnTalent",
         "LeaveBattlefield",
         "LeaveChannelByLocalID",

Modules/Config/DefenseSection.lua

@@ -1,4 +1,4 @@
----@type Config
+---@class Config
 local Config = ECSLoader:ImportModule("Config")
 local _Config = Config.private
 
@@ -111,9 +111,7 @@ function _Config:LoadDefenseSection()
                 name = function() return i18n("Defense Rating") end,
                 desc = function() return i18n("Shows/Hides the defense rating.") end,
                 width = 1.5,
-                hidden = function()
-                    return (not ECS.IsWotlk)
-                end,
+                hidden = function() return ECS.IsClassic end,
                 disabled = function() return (not ExtendedCharacterStats.profile.defense.display); end,
                 get = function () return ExtendedCharacterStats.profile.defense.defenseRating.display; end,
                 set = function (_, value)
@@ -192,9 +190,7 @@ function _Config:LoadDefenseSection()
                 name = function() return i18n("Resilience") end,
                 desc = function() return i18n("Shows/Hides the resilience value.") end,
                 width = 1.5,
-                hidden = function()
-                    return (not ECS.IsWotlk)
-                end,
+                hidden = function() return ECS.IsClassic end,
                 disabled = function() return (not ExtendedCharacterStats.profile.defense.display); end,
                 get = function () return ExtendedCharacterStats.profile.defense.resilience.display; end,
                 set = function (_, value)

Modules/Config/GeneralSection.lua

@@ -1,4 +1,4 @@
----@type Config
+---@class Config
 local Config = ECSLoader:ImportModule("Config")
 local _Config = Config.private
 

Modules/Config/ManaSection.lua

@@ -1,4 +1,4 @@
----@type Config
+---@class Config
 local Config = ECSLoader:ImportModule("Config")
 local _Config = Config.private
 
@@ -27,19 +27,6 @@ function _Config:LoadManaSection()
                     Stats.RebuildStatInfos()
                 end,
             },
-            mp5Items = {
-                type = "toggle",
-                order = 1,
-                name = function() return i18n("MP5 Items") end,
-                desc = function() return i18n("Shows/Hides the MP5 value from items.") end,
-                width = 1.5,
-                disabled = function() return (not ExtendedCharacterStats.profile.regen.display); end,
-                get = function () return ExtendedCharacterStats.profile.regen.mp5Items.display; end,
-                set = function (_, value)
-                    ExtendedCharacterStats.profile.regen.mp5Items.display = value
-                    Stats.RebuildStatInfos()
-                end,
-            },
             mp5Spirit = {
                 type = "toggle",
                 order = 2,
@@ -53,19 +40,6 @@ function _Config:LoadManaSection()
                     Stats.RebuildStatInfos()
                 end,
             },
-            mp5Buffs = {
-                type = "toggle",
-                order = 3,
-                name = function() return i18n("MP5 Buffs") end,
-                desc = function() return i18n("Shows/Hides the MP5 value from buffs.") end,
-                width = 1.5,
-                disabled = function() return (not ExtendedCharacterStats.profile.regen.display); end,
-                get = function () return ExtendedCharacterStats.profile.regen.mp5Buffs.display; end,
-                set = function (_, value)
-                    ExtendedCharacterStats.profile.regen.mp5Buffs.display = value
-                    Stats.RebuildStatInfos()
-                end,
-            },
             mp5Casting = {
                 type = "toggle",
                 order = 4,

Modules/Config/MeleeSection.lua

@@ -1,4 +1,4 @@
----@type Config
+---@class Config
 local Config = ECSLoader:ImportModule("Config")
 local _Config = Config.private
 
@@ -59,9 +59,6 @@ function _Config:LoadMeleeSection()
                 name = function() return i18n("Armor Pen.") end,
                 desc = function() return i18n("Shows/Hides the armor penetration value.") end,
                 width = 1.5,
-                hidden = function()
-                    return (not ECS.IsWotlk)
-                end,
                 disabled = function() return (not ExtendedCharacterStats.profile.melee.display); end,
                 get = function () return ExtendedCharacterStats.profile.melee.penetration.display; end,
                 set = function (_, value)
@@ -75,9 +72,7 @@ function _Config:LoadMeleeSection()
                 name = function() return i18n("Armor Pen. Rating") end,
                 desc = function() return i18n("Shows/Hides the armor penetration rating value.") end,
                 width = 1.5,
-                hidden = function()
-                    return (not ECS.IsWotlk)
-                end,
+                hidden = function() return ECS.IsClassic end,
                 disabled = function() return (not ExtendedCharacterStats.profile.melee.display); end,
                 get = function () return ExtendedCharacterStats.profile.melee.penetrationRating.display; end,
                 set = function (_, value)
@@ -91,9 +86,7 @@ function _Config:LoadMeleeSection()
                 name = function() return i18n("Expertise") end,
                 desc = function() return i18n("Shows/Hides the expertise value.") end,
                 width = 1.5,
-                hidden = function()
-                    return (not ECS.IsWotlk)
-                end,
+                hidden = function() return ECS.IsClassic end,
                 disabled = function() return (not ExtendedCharacterStats.profile.melee.display); end,
                 get = function () return ExtendedCharacterStats.profile.melee.expertise.display; end,
                 set = function (_, value)
@@ -107,9 +100,7 @@ function _Config:LoadMeleeSection()
                 name = function() return i18n("Expertise Rating") end,
                 desc = function() return i18n("Shows/Hides the expertise rating.") end,
                 width = 1.5,
-                hidden = function()
-                    return (not ECS.IsWotlk)
-                end,
+                hidden = function() return ECS.IsClassic end,
                 disabled = function() return (not ExtendedCharacterStats.profile.melee.display); end,
                 get = function () return ExtendedCharacterStats.profile.melee.expertiseRating.display; end,
                 set = function (_, value)
@@ -123,9 +114,7 @@ function _Config:LoadMeleeSection()
                 name = function() return i18n("Haste Rating") end,
                 desc = function() return i18n("Shows/Hides the melee haste rating.") end,
                 width = 1.5,
-                hidden = function()
-                    return (not ECS.IsWotlk)
-                end,
+                hidden = function() return ECS.IsClassic end,
                 disabled = function() return (not ExtendedCharacterStats.profile.melee.display); end,
                 get = function () return ExtendedCharacterStats.profile.melee.hasteRating.display; end,
                 set = function (_, value)
@@ -139,9 +128,6 @@ function _Config:LoadMeleeSection()
                 name = function() return i18n("Haste Bonus") end,
                 desc = function() return i18n("Shows/Hides the melee haste bonus value.") end,
                 width = 1.5,
-                hidden = function()
-                    return (not ECS.IsWotlk)
-                end,
                 disabled = function() return (not ExtendedCharacterStats.profile.melee.display); end,
                 get = function () return ExtendedCharacterStats.profile.melee.hasteBonus.display; end,
                 set = function (_, value)
@@ -174,9 +160,7 @@ function _Config:LoadMeleeSection()
                         name = function() return i18n("Hit Rating") end,
                         desc = function() return i18n("Shows/Hides the melee hit rating.") end,
                         width = 1.5,
-                        hidden = function()
-                            return (not ECS.IsWotlk)
-                        end,
+                        hidden = function() return ECS.IsClassic end,
                         disabled = function()
                             return ((not ExtendedCharacterStats.profile.melee.display) or
                                     (not ExtendedCharacterStats.profile.melee.hit.display))
@@ -243,9 +227,7 @@ function _Config:LoadMeleeSection()
                 name = function() return i18n("Glancing Blow") end,
                 desc = function() return i18n("Shows/Hides all glancing blow stats") end,
                 width = 1.5,
-                hidden = function()
-                    return (not ECS.IsClassic)
-                end,
+                hidden = function() return ECS.IsWotlk end,
                 disabled = function() return (not ExtendedCharacterStats.profile.melee.display); end,
                 get = function () return ExtendedCharacterStats.profile.melee.glance.display; end,
                 set = function (_, value)
@@ -258,9 +240,7 @@ function _Config:LoadMeleeSection()
                 order = 6,
                 inline = true,
                 name = function() return i18n("Melee Glance Values") end,
-                hidden = function()
-                    return (not ECS.IsClassic)
-                end,
+                hidden = function() return ECS.IsWotlk end,
                 args = {
                     meleeGlance = {
                         type = "toggle",
@@ -322,7 +302,7 @@ function _Config:LoadMeleeSection()
                         end,
                         get = function () return ExtendedCharacterStats.profile.melee.glance.damageBossLevel.display; end,
                         set = function (_, value)
-                            ExtendedCharacterStats.profile.melee.glance.damageSameLevel.display = value
+                            ExtendedCharacterStats.profile.melee.glance.damageBossLevel.display = value
                             Stats.RebuildStatInfos()
                         end,
                     },
@@ -383,4 +363,4 @@ function _Config:LoadMeleeSection()
             },
         },
     }
-end
+end

Modules/Config/RangeSection.lua

@@ -1,4 +1,4 @@
----@type Config
+---@class Config
 local Config = ECSLoader:ImportModule("Config")
 local _Config = Config.private
 
@@ -59,9 +59,6 @@ function _Config:LoadRangeSection()
                 name = function() return i18n("Armor Pen.") end,
                 desc = function() return i18n("Shows/Hides the armor penetration value.") end,
                 width = 1.5,
-                hidden = function()
-                    return (not ECS.IsWotlk)
-                end,
                 disabled = function() return (not ExtendedCharacterStats.profile.ranged.display); end,
                 get = function () return ExtendedCharacterStats.profile.ranged.penetration.display; end,
                 set = function (_, value)
@@ -75,9 +72,7 @@ function _Config:LoadRangeSection()
                 name = function() return i18n("Armor Pen. Rating") end,
                 desc = function() return i18n("Shows/Hides the armor penetration rating value.") end,
                 width = 1.5,
-                hidden = function()
-                    return (not ECS.IsWotlk)
-                end,
+                hidden = function() return ECS.IsClassic end,
                 disabled = function() return (not ExtendedCharacterStats.profile.ranged.display); end,
                 get = function () return ExtendedCharacterStats.profile.ranged.penetrationRating.display; end,
                 set = function (_, value)
@@ -91,9 +86,7 @@ function _Config:LoadRangeSection()
                 name = function() return i18n("Haste Rating") end,
                 desc = function() return i18n("Shows/Hides the ranged haste rating.") end,
                 width = 1.5,
-                hidden = function()
-                    return (not ECS.IsWotlk)
-                end,
+                hidden = function() return ECS.IsClassic end,
                 disabled = function() return (not ExtendedCharacterStats.profile.ranged.display); end,
                 get = function () return ExtendedCharacterStats.profile.ranged.hasteRating.display; end,
                 set = function (_, value)
@@ -107,9 +100,6 @@ function _Config:LoadRangeSection()
                 name = function() return i18n("Haste Bonus") end,
                 desc = function() return i18n("Shows/Hides the ranged haste bonus value.") end,
                 width = 1.5,
-                hidden = function()
-                    return (not ECS.IsWotlk)
-                end,
                 disabled = function() return (not ExtendedCharacterStats.profile.ranged.display); end,
                 get = function () return ExtendedCharacterStats.profile.ranged.hasteBonus.display; end,
                 set = function (_, value)
@@ -155,9 +145,7 @@ function _Config:LoadRangeSection()
                         name = function() return i18n("Hit Rating") end,
                         desc = function() return i18n("Shows/Hides the ranged hit rating.") end,
                         width = 1.5,
-                        hidden = function()
-                            return (not ECS.IsWotlk)
-                        end,
+                        hidden = function() return ECS.IsClassic end,
                         disabled = function()
                             return ((not ExtendedCharacterStats.profile.ranged.display) or
                                     (not ExtendedCharacterStats.profile.ranged.hit.display))

Modules/Config/SpellSchoolsSection.lua

@@ -1,4 +1,4 @@
----@type Config
+---@class Config
 local Config = ECSLoader:ImportModule("Config")
 local _Config = Config.private
 

Modules/Config/SpellSection.lua

@@ -1,4 +1,4 @@
----@type Config
+---@class Config
 local Config = ECSLoader:ImportModule("Config")
 local _Config = Config.private
 
@@ -46,9 +46,7 @@ function _Config:LoadSpellSection()
                 name = function() return i18n("Haste Rating") end,
                 desc = function() return i18n("Shows/Hides the spell haste rating value.") end,
                 width = 1.5,
-                hidden = function()
-                    return (not ECS.IsWotlk)
-                end,
+                hidden = function() return ECS.IsClassic end,
                 disabled = function() return (not ExtendedCharacterStats.profile.spell.display); end,
                 get = function () return ExtendedCharacterStats.profile.spell.hasteRating.display; end,
                 set = function (_, value)
@@ -62,9 +60,6 @@ function _Config:LoadSpellSection()
                 name = function() return i18n("Haste Bonus") end,
                 desc = function() return i18n("Shows/Hides the spell haste bonus value.") end,
                 width = 1.5,
-                hidden = function()
-                    return (not ECS.IsWotlk)
-                end,
                 disabled = function() return (not ExtendedCharacterStats.profile.spell.display); end,
                 get = function () return ExtendedCharacterStats.profile.spell.hasteBonus.display; end,
                 set = function (_, value)
@@ -97,9 +92,7 @@ function _Config:LoadSpellSection()
                         name = function() return i18n("Hit Rating") end,
                         desc = function() return i18n("Shows/Hides the spell hit rating.") end,
                         width = 1.5,
-                        hidden = function()
-                            return (not ECS.IsWotlk)
-                        end,
+                        hidden = function() return ECS.IsClassic end,
                         disabled = function()
                             return ((not ExtendedCharacterStats.profile.spell.display) or
                                     (not ExtendedCharacterStats.profile.spell.hit.display))