New rexray install image to support driver reinstallation and version update#29
Open
kaustavb12 wants to merge 2 commits intoBretFisher:mainfrom
Open
New rexray install image to support driver reinstallation and version update#29kaustavb12 wants to merge 2 commits intoBretFisher:mainfrom
kaustavb12 wants to merge 2 commits intoBretFisher:mainfrom
Conversation
Owner
|
Thanks for the tool and script @kaustavb12. I'm going to leave this PR here rather than merge for teaching reasons, rather than merging. Since this is a learning repo, I'm hesitant to add too much magic and would rather people see the "manual" way to do it, and then see this PR for an alternative approach. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the rexray related TODO points mentioned in the stack file:
Changed restart_policy to on-failure. New script detects if plugin already installed and reinstalls if given version is different from installed version or does nothing if version matches. This behavior can be tweaked using script options.
Specific driver version given for script to install. Can rerun script providing different version to update driver as required. Can also configure script options to reinstall using the 'latest' tag each time it runs.
Using rexray-plugin-installer project that I created. Below are the links:
GitHub:
https://github.com/kaustavb12/rexray-plugin-installer
Docker Hub:
https://hub.docker.com/r/kaustavb12/rexray-plugin-installer