Fix int/pointer conversion errors that break GCC 14+ builds - #81
Merged
Conversation
BANK_2_ADDRESS and SD_BOOTLOADER_ADDRESS are plain integer literals, but 974c49b assigned them to a uint32_t* and passed that pointer back into set_bootloader(uint32_t). GCC <=13 only warned; GCC 14+ makes -Wint-conversion an error by default, breaking the build on current toolchains. Fixes #80 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BANK_2_ADDRESS/SD_BOOTLOADER_ADDRESSare plain int literals; 974c49b assigned them to auint32_t *and passed that pointer back intoset_bootloader(uint32_t). GCC <=13 warned, GCC 14+ errors (-Wint-conversionis an error by default). Added the casts — no behavior change.Verified with Arm GNU Toolchain 15.2.Rel1: full mario and zelda builds pass, and
main.ccompiles clean underSD_BOOTLOADER/TRIPLE_BOOT/CLOCK_ONLY/ENABLE_SMB1_GRAPHIC_MODS.Fixes #80
🤖 Generated with Claude Code