Conversation
Obi-Wan
force-pushed
the
multi-channel-support
branch
2 times, most recently
from
12c5eea to
e0eb3f3
Compare
Signed-off-by: Nicola Vigano <nicola.vigano@cea.fr>
Signed-off-by: Nicola Vigano <nicola.vigano@cea.fr>
Signed-off-by: Nicola Vigano <nicola.vigano@cea.fr>
Signed-off-by: Nicola Vigano <nicola.vigano@cea.fr>
Signed-off-by: Nicola Vigano <nicola.vigano@cea.fr>
Signed-off-by: Nicola Vigano <nicola.vigano@cea.fr>
Signed-off-by: Nicola Vigano <nicola.vigano@cea.fr>
The API is now homogeneous across the algorithms. Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Obi-Wan
force-pushed
the
multi-channel-support
branch
from
e0eb3f3 to
a5ffaed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description / Context
Many signals are intrinsically multi-channel across multiple domains in science. Currently, we only offer backend support in the models for multi-channel signals. However, the algorithms do not provide explicit support for them, and might actually hinder the usage of this feature, due to specific assumptions in the data layout.
This PR adds support for multi-channel signals in all the algorithms.
Noise2Voidis currently a second-class citizen, due to its different API. This might change in this PR.TODO
Notes
Coincidentally, this PR adds support for complex data.