Fixed API returning an enum instead of uint64_t.#116
Merged
nayakned merged 1 commit intoCOVESA:mainfrom Feb 16, 2026
Merged
Conversation
Signed-off-by: Naresh Nayak <Naresh.Nayak@de.bosch.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a type mismatch in the Avtp_AcfCommon_GetAcfMsgType function by adding an explicit cast from uint64_t to Avtp_AcfMsgType_t. The function signature declares it returns an enum type, but the macro GET_ACF_COMMON_FIELD returns uint64_t. The cast ensures proper type safety, particularly for C++ compatibility.
Changes:
- Added explicit C-style cast to
Avtp_AcfMsgType_tin the return statement ofAvtp_AcfCommon_GetAcfMsgType
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
Should fix #115 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C++ does not allow returning fixed width integer when enums are expected. Fixed the only one of the APIs which is doing so.