Add OneTimetokenAuthenticator as part of the magic link feature#97
Merged
steinkel merged 1 commit into10.next-cake5from Mar 6, 2025
Merged
Add OneTimetokenAuthenticator as part of the magic link feature#97steinkel merged 1 commit into10.next-cake5from
steinkel merged 1 commit into10.next-cake5from
Conversation
ajibarra
force-pushed
the
feature/magic-link
branch
15 times, most recently
from
3d1d4ba to
272ba5e
Compare
steinkel
requested changes
Feb 14, 2025
Member
steinkel
left a comment
steinkel
left a comment
There was a problem hiding this comment.
please also correct the phpstan related issues
|
|
||
| $usersTable = TableRegistry::getTableLocator()->get(Configure::read('Users.table')); | ||
|
|
||
| $user = $usersTable->loginWithToken($token); |
Member
There was a problem hiding this comment.
we'll need to define an interface, then check it's implemented by the table, or check the method exists
ajibarra
force-pushed
the
feature/magic-link
branch
2 times, most recently
from
7f60077 to
9cbc4ce
Compare
ajibarra
force-pushed
the
feature/magic-link
branch
from
9cbc4ce to
03f427c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.