Add spaces and punctuation in certain chat messages#14759
Open
Andrew5057 wants to merge 3 commits intoCharcoal-SE:masterfrom
Open
Add spaces and punctuation in certain chat messages#14759Andrew5057 wants to merge 3 commits intoCharcoal-SE:masterfrom
Andrew5057 wants to merge 3 commits intoCharcoal-SE:masterfrom
Conversation
"isprimarily" -> "is primarily"; resolves half of [13995](Charcoal-SE#13995).
Add `". "`` after "That pattern looks like it's already
caught by {reasons}" when a user tries to blacklist an
already-caught pattern without forcing. Addresses the
second half of [13995](Charcoal-SE#13995).
The removed leading space in `append_force_to_do` is
meant to avoid double-spaces if no other issues were
raised.
Shorten line 523 to satisfy the linter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a space in "isprimarily" and proper punctuation after the already-caught blacklist message.
Make some internal changes to simplify chat message assembly; most notably, remove the leading space from
append_force_to_dofor consistency with other message fragments sostr.joinworks properly.Addresses 13995.