Skip to content

fix(subsonic): fix search3 empty query sync, correct lyrics route and…#190

Open
cachamber wants to merge 2 commits into
Chevron7Locked:mainfrom
cachamber:subsonic_debug
Open

fix(subsonic): fix search3 empty query sync, correct lyrics route and…#190
cachamber wants to merge 2 commits into
Chevron7Locked:mainfrom
cachamber:subsonic_debug

Conversation

@cachamber

Copy link
Copy Markdown
Contributor

Description

Subsonic: add the following

  • request tracing
  • search3 empty-query sync support
  • lyrics v2 support
  • lyrics parity with web route

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Enhancement (improvement to existing functionality)
  • Documentation update
  • Code cleanup / refactoring
  • Other (please describe):

Related Issues

Fixes #182

Changes Made

  • search3 implementation wasn't correct - short circuit to return if query was empty
  • update Subsonic Extensions to return correct format
  • lyrics route now follows web route
  • add lyrics v2 support
  • add subsonic request tracing
  • add subsonic route tests for search and lyrics

Testing Done

  • Tested locally with Docker
  • Tested specific functionality:
    -- Tested and validated with Symfonium 14.1.0 on android
    -- Tested and validated with Amperfy 2.1.0 build 21 on iphone

Screenshots (if applicable)

Amperfy (iphone)
Amperfy 2.1.0 b21
Symfonium (android)
Symfonium 14.1.0

Checklist

  • My code follows the project's code style
  • I have tested my changes locally
  • I have updated documentation if needed
  • My changes don't introduce new warnings
  • This PR targets the main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: No lyrics or artist images on Symphonium using Subsonic

1 participant