Fix input collapses for multi select & no placeholder & no initial selection

[muendlein]

Description

Fixes #1368

Types of changes

• Chore (tooling change or documentation change)
• Refactor (non-breaking change which maintains existing functionality)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

• My code follows the code style of this project.
• I have added new tests for the bug I fixed/the new feature I added.
• I have modified existing tests for the bug I fixed/the new feature I added.

[Xon]

Any reason to not simplify this check to just?
else if (this._store.items.length) {

[muendlein]

I'm not sure if I fully understand your suggestion but if (this._store.items.length) should always evaluate to true as items are initialized as [].

[Xon]

In javascript, [].length === 0. but if length is a positive value, then it is truthy. However the real fix probably should be in setWidth

  setWidth(): void {
    // Resize input to contents or placeholder
    const { element } = this;
    element.style.minWidth = `${element.placeholder.length + 1}ch`;
    element.style.width = `${element.value.length + 1}ch`;
  }

This should have had a minimum length of 1, but obviously something isn't working as expected; likely for element.value.length term.

[Xon]

The this._store.items aren't populated when _createStructure() is called, so this check doesn't work as expected

[Xon]

Looking into this more, removing the logic which reduces the input to 1ch causes reflow issues when multiple items are selected on a narrow enough display port

[Xon]

Ah, after some tinkering this is a more general issue with no placeholders or no items causing the total height of the entire choices.js widget to dramatically shrink.

This change doesn't fix that, and just bandaids the issue